Re: [PATCH BlueZ] build: Fix make distcheck for input plugin

On Tue, Nov 13, 2012 at 10:52 AM, Anderson Lizardo
[off-list ref] wrote:

Hi Lucas,

On Tue, Nov 13, 2012 at 8:21 AM, Lucas De Marchi
[off-list ref] wrote:

quoted

On Mon, Nov 12, 2012 at 7:03 PM, Anderson Lizardo
[off-list ref] wrote:

quoted

suspend.c is a symlink generated at build time, therefore it should be
created on build directory. Additionally, it is necessary to add
-I$(srcdir)/profiles/input to CPPFLAGS so suspend.h can be found (the
compiler does not follow symlinks prior to resolving #include
directives).
---
 Makefile.am |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Makefile.am b/Makefile.am
index d49e8a0..c398e74 100644
--- a/Makefile.am
+++ b/Makefile.am

@@ -366,6 +366,10 @@ if MCAP
 AM_CPPFLAGS += -I$(builddir)/health
 endif

+if HOGPLUGIN
+AM_CPPFLAGS += -I$(srcdir)/profiles/input
+endif

Humn... maybe we need to review these CPPFLAGS for plugins. Appending
it to AM_CPPFLAGS means that every single source file has
"-I$(srcdir)/profiles/input". Even those sources not at all related to
HOGPLUGIN.

However the only way I can think to fix it is by creating convenience
libs since autofoo doesn't support CPPFLAGS per source file.

I agree it is not the best solution. Actually, I think we can overcome
the problem completely by getting rid of symlinks for "drivers" (like
sap-{u8500,dummy}.c, suspend-dummy.c,
telephony-{dummy,maemo5,maemo6,ofono}.c) and having everything
built-in and enabled/disabled based on which D-Bus services are
running on the system (or, if not possible, by using config options).

what do you mean by "running on the system"?

Lucas De Marchi