Re: [PATCH 1/4] adapter: Convert storage aliases
flat view
From: Johan Hedberg <hidden>
Date: 2012-11-14 10:45:53
Hi Frederic, On Wed, Nov 14, 2012, Frédéric Danis wrote:
quoted hunk ↗ jump to hunk
#define SETTINGS_PATH STORAGEDIR "/%s/settings" #define CACHE_PATH STORAGEDIR "/%s/cache/%s" +#define DEVICE_INFO_PATH STORAGEDIR "/%s/%s/info"
Why do you have these separate defines? Do you need them in multiple places? The define names are longer than the actual values and you're just obfuscating the actual call that uses them (since you need to look in two places to figure out of the format parameters are actually matching the format string). So please don't use these. Johan