Re: [PATCH BlueZ] hciconfig: Add an option to set which advertise type will be on

Hi Jefferson,

On Wed, Nov 21, 2012, Jefferson Delfes wrote:

+	if (opt == NULL || strcmp(opt, "noleadv")) {

Wouldn't it be more intuitive to compare against "leadv" here instead of
"noleadv". Also whenever doing strcmp comparisons please use an explicit
== 0 or != 0. Also, if the logic (and length) of this function starts
growing too much you should really consider splitting it into one per
command.

Johan