Thread (20 messages) 20 messages, 3 authors, 2012-10-12

Re: [PATCH -v2 3/8] Bluetooth: Remove parent socket usage from l2cap_core.c

From: Marcel Holtmann <marcel@holtmann.org>
Date: 2012-10-11 13:45:53

Hi Gustavo,
We can lock the parent lock only inside the new_connection() call,
then we just use the l2cap_chan_lock() in core code.

Signed-off-by: Gustavo Padovan <redacted>
---
 net/bluetooth/l2cap_core.c | 16 ++++++----------
 net/bluetooth/l2cap_sock.c |  9 ++++++++-
 2 files changed, 14 insertions(+), 11 deletions(-)
I am fine with this patch under the premise that 2/8 is properly
explained. And here you need to also get into a bit more detail. With
any kind of locking changes, I expect a proper commit message explaining
why this is safe.

Regards

Marcel

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help