Re: [PATCH v2] gatt: Delay D-Bus reply on char discovery

Anderson,

On 09/11/2012 02:44 PM, Anderson Lizardo wrote:

Hi Chen,

On Tue, Sep 11, 2012 at 4:47 AM,  [off-list ref] wrote:

quoted

From: Chen Ganir <redacted>

Delay sending the D-Bus reply for the discover_characteristics
command. The D-Bus reply for characteristics is sent before all
the relevant characteristic information is gathered. This can
cause problems, when trying to get characteristic information too
soon. This patch moves the D-Bus reply to the end of the char
discovery process. Only after all descriptors are discovered and
read, the D-Bus reply is sent.
---

I see you populate chr->descriptors, but I can't find where the list
is actually used. Do you plan to use this information in some other
patch?

Regards,

The plan is to replace characteristic::format, and add CCC, SCC and any 
other descriptor we find in the future to this list. This way we have a 
unified list of descriptors and the data contained in them. This is 
already done in some patches i already have, which rely on this patch. 
Next patch set includes notification/indication implementation to the 
D-Bus API (Auto registration to notification/indication if CCC is found).

-- 
BR,
Chen Ganir