Thread (18 messages) flat view 18 messages, 2 authors, 2012-09-21

Re: [PATCH v6 11/13] heartrate: Add GetProperties method

From: Johan Hedberg <hidden>
Date: 2012-09-21 13:45:37

Hi Andrzej,

On Thu, Sep 20, 2012, Andrzej Kaczmarek wrote:
+static const char * const location_enum[] = {
+	"Other",
+	"Chest",
+	"Wrist",
+	"Finger",
+	"Hand",
+	"Earlobe",
+	"Foot"
+};
Please add a "," to the end of the last entry to make patches that add
new entries look nicer (they don't have to first remove the last line
and then add two new lines).

Also, is the "const * const" stuff really needed? I think in most places
in the code base with tables like this we've just left out the second
one.

Johan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help