Re: [PATCH v3 07/18] neard: Implement PushOOB function

Hi Szymon,

On Fri, Sep 21, 2012, Szymon Janc wrote:

+static struct btd_adapter *pending_adapter = NULL;
+static DBusMessage *pending_msg = NULL;

I'm not really a fan of these global variables. Any chance of moving
them to a non-global temporary context that gets passed around. In
general I find it hard to get the big picture on the life-time of these
variables as it seems you don't actually explicitly initiate the pairing
process from your code but are relying on some external entity to do
that? Or did I miss something? The whole thing just looks quite brittle
right now.

Johan