Thread (18 messages) flat view 18 messages, 2 authors, 2012-07-17

Re: [PATCH v12 13/13] audio: Add fast connectable to telephony interface

From: Frederic Danis <hidden>
Date: 2012-07-17 08:23:06

Hello Johan,

On 17/07/2012 10:10, Johan Hedberg wrote:
Hi Frédéric,

On Thu, Jul 12, 2012, Frédéric Danis wrote:
quoted
+# Telephony interface specific options (i.e. options which affect how the
+# service interacts with remote devices)
+[Telephony]
+
+# Set to true to enable agent to use of fast connectable mode (faster page
+# scanning) when incoming call starts. Default settings should be restored
+# after call is answered or rejected. Page scan interval is much shorter and
+# page scan type changed to interlaced. Such allows faster connection
+# initiated by a headset.
+FastConnectable=false
I don't really see the point of making this configurable and add extra
code complexity because of it. There should be no reason why it couldn't
always be available to the telephony agent. So unless you have a really
good reason for keeping it could you please remove it.
OK, I will remove it

Fred


-- 
Frederic Danis                            Open Source Technology Center
frederic.danis@intel.com                              Intel Corporation


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help