Re: [PATCH v13 12/14] audio: Add DUN GW to org.bluez.Telephony

Hi Frédéric,

On Tue, Jul 17, 2012, Frédéric Danis wrote:

+static void client_connect_cb(GIOChannel *chan, GError *err,
+				gpointer user_data)
+{
+	struct tel_client *client = user_data;
+	char hs_address[18];
+
+	if (err) {
+		error("%s", err->message);
+		goto done;
+	}
+
+	ba2str(&client->dst, hs_address);
+
+	telephony_device_connecting(chan, client->btd_dev, client,
+				    client->agent);

Firstly, you've got the wrong indentation above. Only tabs please.

Secondly, this is exactly the kind of crap that happens when you start
using void * everywhere instead of proper types. The function
telephony_device_connecting casts the third parameter ("client" above)
to struct audio_device. See the problem?

Johan