Re: [PATCH BlueZ 1/5] gdbus: Add skeleton of DBus.Properties interface

Hi Lucas,

quoted

quoted

This interface is responsible for handling properties of all objects in
a given path. Right now it only registers itself, doing nothing useful.
A conversion to this new layout will be done by subsequent patches.

org.freedesktop.org.DBus.Properties spec can be found at
http://dbus.freedesktop.org/doc/dbus-specification.html#standard-interfaces-properties
---
 gdbus/object.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 48 insertions(+)

diff --git a/gdbus/object.c b/gdbus/object.c
index 900e7ab..72f77d4 100644
--- a/gdbus/object.c
+++ b/gdbus/object.c

@@ -491,6 +491,50 @@ static const GDBusMethodTable introspect_methods[] = {
      { }
 };

+static DBusMessage *properties_get(DBusConnection *connection,
+                                     DBusMessage *message, void *user_data)
+{
+     return NULL;
+}
+
+static DBusMessage *properties_get_all(DBusConnection *connection,
+                                     DBusMessage *message, void *user_data)
+{
+     return NULL;
+}
+
+static DBusMessage *properties_set(DBusConnection *connection,
+                                     DBusMessage *message, void *user_data)
+{
+     return NULL;
+}
+
+static const GDBusMethodTable properties_methods[] = {
+     { GDBUS_METHOD("Get",
+                     GDBUS_ARGS({ "interface_name", "s" },
+                                             { "property_name", "s" }),

this should be "interface" and "name". Why are we so verbose here?

I put the same name as in spec:
http://dbus.freedesktop.org/doc/dbus-specification.html#standard-interfaces-properties

quoted

quoted

+                     GDBUS_ARGS({ "value", "v" }),
+                     properties_get) },
+     { GDBUS_METHOD("Set", NULL,
+                     GDBUS_ARGS({ "interface_name", "s" },
+                                     { "property_name", "s" },
+                                     { "value", "v" }),
+                     properties_set) },
+     { GDBUS_METHOD("GetAll",
+                     GDBUS_ARGS({ "interface_name", "s" }),
+                     GDBUS_ARGS({ "props", "a{sv}" }),

And this should be "properties". Here you are trying to be super short.

same here.


should I change or let as is?

it is inconsistent at least. On one method you use props on the other it
is *_properties. No matter what the specification says, that is just
stupid. And the _name suffix is useless in this context. So yes, please
just change it.

Regards

Marcel
h