Thread (11 messages) flat view 11 messages, 3 authors, 2012-07-19

Re: Re: [PATCH 1/2] Bluetooth: Fix legacy pairing with some devices

From: Szymon Janc <hidden>
Date: 2012-07-19 09:13:12

(as plain text this time..)

Hi Gustavo & Johan,
quoted
quoted
Maybe we could set timeout back to HCI_DICONN_TIMEOUT when l2cap is
connected (or disconnected)? That should cover SDP search case..
What happened to getting this patch upstream? To me it looks like a
definitely needed fix. After adding the fix to restore a sensible value
for disc_timeout after an L2CAP connect request either way and adding a
better explanation to the commit message (that we only get the PIN
request after user has entered one on the remote side, including a
hcidump of this) I think this should go upstream. If this had been
processed in a timely manner it could have made it to 3.5 but now it
seems too late for that (as it's not strictly speaking a regression from
3.4).
Could you re-do this patch as Johan says so we can try push it to 3.5?
Sorry for late reply, been on rather long holiday..

I now feel that this is a bug in bluez not in kernel - bluez should not cancel
PIN request for agent if acl is disconnected but just reconnect when PIN is
provided.

So, if you still like to have this workaround in kernel for devices which are
highly unlikely to have this fixed I can send new version.

--
BR
Szymon Janc
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help