Thread (3 messages) 3 messages, 2 authors, 2012-07-24

Re: [RFC v0] media: Extend media API with optional acquire

From: Mikel Astiz <hidden>
Date: 2012-07-24 15:39:31

Hi Luiz,

On Mon, Jul 16, 2012 at 11:17 AM, Luiz Augusto von Dentz
[off-list ref] wrote:
Hi Mikel,

On Mon, Jul 9, 2012 at 5:21 PM, Mikel Astiz [off-list ref] wrote:
quoted
From: Mikel Astiz <redacted>
 unsigned int gateway_request_stream(struct audio_device *dev,
+                               gboolean try_only,
                                gateway_stream_cb_t cb, void *user_data)
 {
        struct gateway *gw = dev->gateway;
        GError *err = NULL;
        GIOChannel *io;

+       if (try_only && !gw->sco)
+               return 0;
Perhaps if we store the status of the transport we don't need to even
call gateway_request_stream.
I tried to follow this approach by adding a flag (gboolean playing)
inside struct media_transport, avoiding changes in the transport
callbacks.

Patches will be submitted soon.

Cheers,
Mikel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help