Thread (7 messages) 7 messages, 2 authors, 2012-07-26

Re: [RFC v1 0/4] Optional acquire in Media API

From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: 2012-07-26 08:03:47

Hi Mikel,

On Tue, Jul 24, 2012 at 6:52 PM, Mikel Astiz [off-list ref] wrote:
From: Mikel Astiz <redacted>

This patch series adds a flag to the Acquire method in the Media API, in order to fix the race condition described in patch v1 3/4.

v1 tries to follow the proposal from Luiz by avoiding changes in the internal callbacks, and instead using the state information available in struct media_transport.

Patch v1 4/4 needs careful review since the replacement of the in_use flag is not trivial.

From original patch:

This patch reopens the discussion started by the thread "when is acquire
ok to call". The race condition seems to be real (even thought difficult
to reproduce), and I couldn't think of any approach to solve this
without altering the Media API.
Btw, I guess it is important to clarify that this doesn't break the
API as the new flag is ignored in previous versions. The other
important thing to mention is that this flag is not specific to one
role, otherwise we would have done this without adding a new API,
because there could be some situations where the transport must be
connected regardless of the role.

-- 
Luiz Augusto von Dentz
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help