Thread (3 messages) 3 messages, 3 authors, 2012-08-13
STALE5095d

[PATCH] input: Fix crash when connecting HID keyboard

From: Andrzej Kaczmarek <hidden>
Date: 2012-07-31 12:48:24
Subsystem: the rest · Maintainer: Linus Torvalds

hidp_add_connection should return after setting up security watch when
connecting HID keyboard, otherwise req will be freed and encrypt_notify
callback will receive invalid pointer.
---
 profiles/input/device.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/profiles/input/device.c b/profiles/input/device.c
index ed178b4..48d397a 100644
--- a/profiles/input/device.c
+++ b/profiles/input/device.c
@@ -663,6 +663,8 @@ static int hidp_add_connection(const struct input_device *idev,
 		iconn->req = req;
 		iconn->sec_watch = g_io_add_watch(iconn->intr_io, G_IO_OUT,
 							encrypt_notify, iconn);
+
+		return 0;
 	}
 
 	err = ioctl_connadd(req);
-- 
1.7.11.3
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help