Thread (2 messages) flat view 2 messages, 2 authors, 2012-06-07

Re: [PATCH v1] Bluetooth: Fix LE pairing completion on connection failure

From: Johan Hedberg <hidden>
Date: 2012-06-07 09:18:25

Hi Vishal,

On Thu, Jun 07, 2012, Vishal Agarwal wrote:
+static void le_connect_complete_cb(struct hci_conn *conn, u8 status)
+{
+	struct pending_cmd *cmd;
+
+	BT_DBG("status %u", status);
+
+	if (!status && conn->type == LE_LINK)
+		return;
The patch looks good to me except that this test for LE_LINK seems
unnecessary since this callback is anyway only used for LE. Could you
remove it?

Johan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help