Re: [PATCH] bluetooth: opcode field of sent commands is little endian.
From: Marcel Holtmann <marcel@holtmann.org>
Date: 2012-06-25 06:59:30
Also in:
linuxppc-dev
Hi Michel,
quoted hunk ↗ jump to hunk
Fixes built-in Bluetooth not working on Apple PowerBooks, regression from commit 75fb0e324daa48ec458fb5c2960eb07b80cfad9d ('Bluetooth: Fix init sequence for some CSR based controllers'). Cc: stable@vger.kernel.org [v3.4] Signed-off-by: Michel Dänzer <redacted> --- net/bluetooth/hci_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c index d6dc44c..e039e3d 100644 --- a/net/bluetooth/hci_core.c +++ b/net/bluetooth/hci_core.c@@ -92,7 +92,7 @@ void hci_req_complete(struct hci_dev *hdev, __u16 cmd, int result) * command. */ - if (cmd != HCI_OP_RESET || sent->opcode == HCI_OP_RESET) + if (cmd != HCI_OP_RESET || sent->opcode == cpu_to_le16(HCI_OP_RESET)) return;
actually you could use __constant_cpu_to_le16() here.
That said, this got actually fixed differently upstream. So I prefer if
that patch gets merged into stable and not this one.
commit 1036b89042df96e71c0cb941be212f8053ecccc0
Author: Andrei Emeltchenko [off-list ref]
Date: Mon Mar 12 15:59:33 2012 +0200
Bluetooth: Fix opcode access in hci_complete
In general patches need to get into Linus' tree first before you can
even request them for stable.
Regards
Marcel