Thread (12 messages) 12 messages, 3 authors, 2012-05-25

Re: [PATCH BlueZ 4/6] audio: Fix signature type for transport Volume

flat view

From: Lucas De Marchi <hidden>
Date: 2012-05-24 16:50:39

On Thu, May 24, 2012 at 10:22 AM, Luiz Augusto von Dentz
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Luiz Augusto von Dentz <redacted>

Signature is now uint16 instead of byte
---
 audio/transport.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/audio/transport.c b/audio/transport.c
index 4ad8608..6ed5d21 100644
--- a/audio/transport.c
+++ b/audio/transport.c
@@ -1076,5 +1076,5 @@ void media_transport_update_volume(struct media_transport *transport,
       emit_property_changed(transport->conn, transport->path,
                               MEDIA_TRANSPORT_INTERFACE, "Volume",
-                               DBUS_TYPE_BYTE, &transport->volume);
+                               DBUS_TYPE_UINT16, &transport->volume);
If you are changing it to uint16_t, why are you saying it's a "fix"?

You should change transport->volume type together with this patch as well.


Lucas De Marchi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help