Re: [PATCH] Heart Rate Profile API

Hi,

2012/3/3 Anderson Lizardo [off-list ref]:

Hi Johan,

On Fri, Mar 2, 2012 at 7:57 PM, Johan Hedberg [off-list ref] wrote:

quoted

Hi Santiago,

On Fri, Feb 24, 2012, Santiago Carot-Nemesio wrote:

quoted

+             Reset()
+
+                     Restart the accumulation of energy expended from zero.
+
+                     Possible Errors: org.bluez.Error.NotSupported
+
+Properties   boolean Reset [readonly]
+
+                     True if energy expended is supportted.

The API looks good to me, but I think ResetSupported would make more
sense for this property name. Also, I'd have expected someone from INdT
to either give an ack or nack for this.

I previously said "Just minor typos below. After they are fixed, I
think it is okay to go upstream."

The typos were fixed on this last version.

Regarding "Reset" -> "ResetSupported", I agree with your suggestion.

Santiago, also take the opportunity to fix another typo (on the
snippet above): supportted -> supported

Ok, I'm sending a new patch with the fixes suggested.