Thread (5 messages) 5 messages, 2 authors, 2012-03-14

Re: [PATCH v2 3/3] GATT: Profile support for EnableGatt

flat view

From: Anderson Lizardo <hidden>
Date: 2012-03-14 10:41:30

Hi Chen,

On Wed, Mar 14, 2012 at 6:13 AM,  [off-list ref] wrote:
quoted hunk ↗ jump to hunk
@@ -28,6 +28,7 @@
 #include <stdint.h>
 #include <glib.h>
+#include <errno.h>

 #include "plugin.h"
 #include "hcid.h"
@@ -37,8 +38,8 @@
 static int time_init(void)
 {
       if (!main_opts.gatt_enabled) {
-               DBG("Attribute server is disabled");
-               return -1;
+               DBG("GATT is disabled !");
+               return -ENOTSUP;
Your patch series looks ok, only a minor nitpick: I would use "GATT
support is disabled"  and skip the exclamation.

Regards,
-- 
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help