Thread (12 messages) flat view 12 messages, 3 authors, 2012-03-27

Re: [PATCH v2 5/5] DeviceInfo: Read PNP ID

From: Anderson Lizardo <hidden>
Date: 2012-03-26 15:54:49

Hi Chen,

On Mon, Mar 26, 2012 at 11:25 AM,  [off-list ref] wrote:
quoted hunk ↗ jump to hunk
diff --git a/src/device.c b/src/device.c
index 3b772ee..dad8c26 100644
--- a/src/device.c
+++ b/src/device.c
@@ -131,6 +131,7 @@ struct btd_device {
       gchar           *path;
       char            name[MAX_NAME_LENGTH + 1];
       char            *alias;
+       uint16_t        vendor_src;
       uint16_t        vendor;
       uint16_t        product;
       uint16_t        version;
@@ -377,6 +378,11 @@ static DBusMessage *get_properties(DBusConnection *conn,
               dict_append_entry(&dict, "Vendor", DBUS_TYPE_UINT16,
                                                       &device->vendor);

+       /* Vendor Source*/
+       if (device->vendor_src)
+               dict_append_entry(&dict, "VendorSource", DBUS_TYPE_UINT16,
+                                                       &device->vendor_src);
+
* How does this work for BR/EDR devices (without GATT)? Is zero a
valid value for these devices?

* You need to update doc/device-api.txt

* Vendor Source looks like uint8, but you save it as uint16. Yes, I
know there is no "uint8" for d-bus, but just wondering why "byte"
cannot be used here.

Regards,
-- 
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help