Thread (100 messages) flat view 100 messages, 3 authors, 2012-04-26

Re: [RFCv5 06/26] Bluetooth: A2MP: Add chan callbacks

From: Gustavo Padovan <hidden>
Date: 2012-03-27 16:06:37

* Andrei Emeltchenko [off-list ref] [2012-03-26 14:59:52 +0300]:
Hi Gustavo,

On Sun, Mar 25, 2012 at 02:16:12PM -0300, Gustavo Padovan wrote:
...
quoted
quoted
+static struct sk_buff *a2mp_chan_alloc_skb_cb(struct l2cap_chan *chan,
+					unsigned long len, int nb, int *err)
Wrong coding style here. As we just changed our coding style check the rest of
this patchset for errors like this
I believe that here the style is OK. Otherwise we would have to make
several lines or go outside 80 characters.
Then break it in 3 lines. You have to align everything after the opening "(".

	Gustavo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help