Re: Resend: [PATCH] Bluetooth: Fix Endian Bug.
From: Gustavo Padovan <hidden>
Date: 2012-03-08 05:33:29
Also in:
kernel-janitors, lkml, netdev
Hi Santosh, * santosh nayak [off-list ref] [2012-03-01 22:46:36 +0530]:
quoted hunk ↗ jump to hunk
From: Santosh Nayak <redacted> Fix network to host endian conversion for L2CAP chan id. Signed-off-by: Santosh Nayak <redacted> --- net/bluetooth/l2cap_sock.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)diff --git a/net/bluetooth/l2cap_sock.c b/net/bluetooth/l2cap_sock.c index 401d942..86d5067 100644 --- a/net/bluetooth/l2cap_sock.c +++ b/net/bluetooth/l2cap_sock.c@@ -82,7 +82,7 @@ static int l2cap_sock_bind(struct socket *sock, struct sockaddr *addr, int alen) } if (la.l2_cid) - err = l2cap_add_scid(chan, la.l2_cid); + err = l2cap_add_scid(chan, __le16_to_cpu(la.l2_cid));
This is kind weird, la.l2_cid comes from the user, so it is already in host endian. No need for convertions here. Gustavo