Re: [PATCH] Bluetooth: Remove needless HCI_MGMT flag check
flat view
From: Gustavo Padovan <hidden>
Date: 2012-02-10 16:21:05
Hi Andre, * Andre Guedes [off-list ref] [2012-02-10 10:49:38 -0300]:
quoted hunk ↗ jump to hunk
This patch removes HCI_MGMT flag check in hci_cs_inquiry. There is no need to check this flag before calling mgmt_start_discovery_failed since if the hdev is not managed by mgmt interface this function does nothing. Signed-off-by: Andre Guedes <redacted> --- net/bluetooth/hci_event.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c index b0784ee..5f93fdd 100644 --- a/net/bluetooth/hci_event.c +++ b/net/bluetooth/hci_event.c@@ -1143,8 +1143,7 @@ static inline void hci_cs_inquiry(struct hci_dev *hdev, __u8 status) hci_req_complete(hdev, HCI_OP_INQUIRY, status); hci_conn_check_pending(hdev); hci_dev_lock(hdev); - if (test_bit(HCI_MGMT, &hdev->dev_flags)) - mgmt_start_discovery_failed(hdev, status); + mgmt_start_discovery_failed(hdev, status); hci_dev_unlock(hdev); return; }
Acked-by: Gustavo F. Padovan <redacted> Gustavo