Thread (11 messages) 11 messages, 4 authors, 2012-02-15

Re: [RFC PATCHv2] autopair: add autopair plugin

From: David Herrmann <hidden>
Date: 2012-02-15 17:57:11

Hi Scott

On Tue, Jan 31, 2012 at 12:10 AM, Scott James Remnant
[off-list ref] wrote:
On Mon, Jan 30, 2012 at 3:03 PM, Bastien Nocera [off-list ref] wrote=
:
quoted
Em Mon, 2012-01-30 =E0s 14:35 -0800, Scott James Remnant escreveu:
quoted
On Mon, Jan 30, 2012 at 2:33 PM, Bastien Nocera [off-list ref] wro=
te:
quoted
quoted
quoted
Em Mon, 2012-01-30 =E0s 13:42 -0800, Scott James Remnant escreveu:
quoted
quoted
The PIN length hint is also ignored in the current code:
+ =A0 =A0 =A0 <device type=3D"audio" oui=3D"00:1A:80:" name=3D"CMT=
-DH5BT"
quoted
quoted
quoted
quoted
pin=3D"max:4"/>
quoted
Because that's a UI restriction, no?

I didn't put any PIN-generation code here, because I'm not entirely
sure what the UI for "generate random PIN' should look like or which
spec you're following.
It means that a generated PIN shouldn't have more than 4 digits for i=
t
quoted
quoted
quoted
to work with this device.
What generated PIN? Which spec/profile says you have to generate a PIN
for this device?
It's recommended that the UIs try to generate PINs for the users, rather
than relying on them entering random numbers.
Recommended where? Can you point at least at the correct document?

The only recommendation I'm aware of is in the HID profile, which
would not apply here, and strangely you don't use this max: form for
keyboards which would be the only devices they applied to.


The description matches the HID profile behavior I've sumitted as a
separate set of CLs.
Any update on this plugin? It would make the wiimote plugin obsolete
and allow us to select PINs based on device-names.

If you do not intend to continue your work here I will try fixing the
stuff and resubmit it.

Regards
David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help