[RFCv5 00/16] Bluetooth: Change socket lock to l2cap_chan lock · Emeltchenko Andrei <hidden> · 2012-02-17
[RFCv5 01/16] Bluetooth: trivial: Fix long line · Emeltchenko Andrei <hidden> · 2012-02-17
[RFCv5 02/16] Bluetooth: Revert to mutexes from RCU list · Emeltchenko Andrei <hidden> · 2012-02-17
Re: [RFCv5 02/16] Bluetooth: Revert to mutexes from RCU list · Ulisses Furquim <hidden> · 2012-02-17
Re: [RFCv5 02/16] Bluetooth: Revert to mutexes from RCU list · Andrei Emeltchenko <hidden> · 2012-02-19
Re: [RFCv5 02/16] Bluetooth: Revert to mutexes from RCU list · Ulisses Furquim <hidden> · 2012-02-20
Re: [RFCv5 02/16] Bluetooth: Revert to mutexes from RCU list · Andrei Emeltchenko <hidden> · 2012-02-20
[RFCv5 03/16] Bluetooth: Lock chan list when deleting chan · Emeltchenko Andrei <hidden> · 2012-02-17
[RFCv5 04/16] Bluetooth: Do not use sk lock in get_chan functions · Emeltchenko Andrei <hidden> · 2012-02-17
[RFCv5 05/16] Bluetooth: Add l2cap_chan_lock · Emeltchenko Andrei <hidden> · 2012-02-17
[RFCv5 06/16] Bluetooth: Add locked and unlocked state_change · Emeltchenko Andrei <hidden> · 2012-02-17
[RFCv5 07/16] Bluetooth: Add socket error function · Emeltchenko Andrei <hidden> · 2012-02-17
[RFCv5 08/16] Bluetooth: Add unlocked __l2cap_chan_add function · Emeltchenko Andrei <hidden> · 2012-02-17
[RFCv5 09/16] Bluetooth: Use chan lock in timers · Emeltchenko Andrei <hidden> · 2012-02-17
[RFCv5 10/16] Bluetooth: Use chan lock in L2CAP sig commands · Emeltchenko Andrei <hidden> · 2012-02-17
[RFCv5 11/16] Bluetooth: Use chan lock in L2CAP conn start · Emeltchenko Andrei <hidden> · 2012-02-17
[RFCv5 12/16] Bluetooth: Use chan lock in receiving data · Emeltchenko Andrei <hidden> · 2012-02-17
[RFCv5 13/16] Bluetooth: Change locking logic for conn/chan ready · Emeltchenko Andrei <hidden> · 2012-02-17
[RFCv5 14/16] Bluetooth: Change locking logic in security_cfm · Emeltchenko Andrei <hidden> · 2012-02-17
[RFCv5 15/16] Bluetooth: Use l2cap chan lock in socket connect · Emeltchenko Andrei <hidden> · 2012-02-17
[RFCv5 16/16] Bluetooth: Remove socket lock check · Emeltchenko Andrei <hidden> · 2012-02-17

Re: [RFCv5 02/16] Bluetooth: Revert to mutexes from RCU list

From: Andrei Emeltchenko <hidden>
Date: 2012-02-19 19:49:08

Hi Ulisses,

On Fri, Feb 17, 2012 at 11:22 PM, Ulisses Furquim
[off-list ref] wrote:

Why don't you squash together patches 2, 3 and 4? Is there a reason?

The price of squashing is zero and if there are no other comments I
can do it right away.

Only with patch 2 the change becomes incomplete and prone to errors.

However I do not think that this makes much difference to the existing code.

With patch 3 you add some needed changes but then adds an imbalance of
lock/release sock locks which is only solved in patch 4. Why?

How does patch 4 solves locking? If I did not miss something it shall
not change anything.

Regards,
Andrei

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help