Thread (18 messages) flat view 18 messages, 2 authors, 2012-02-21

Re: [PATCH obexd 2/9] client: fix obc_session_get_buffer

From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: 2012-02-21 11:07:53

Hi Mikel,

On Tue, Feb 21, 2012 at 10:46 AM, Mikel Astiz [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Mikel Astiz <redacted>

Size 0 should be reported if no transfer exists. Some existing code
relies on this behavior.
---
 client/session.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/client/session.c b/client/session.c
index 85f466a..e113d1f 100644
--- a/client/session.c
+++ b/client/session.c
@@ -1128,8 +1128,12 @@ const char *obc_session_get_buffer(struct obc_session *session, size_t *size)
       const char *buf;

       transfer = obc_session_get_transfer(session);
-       if (transfer == NULL)
+       if (transfer == NULL) {
+               if (size != NULL)
+                       *size = 0;
+
               return NULL;
+       }

       buf = obc_transfer_get_buffer(transfer, size);

--
1.7.6.5
Nice catch, ack.

-- 
Luiz Augusto von Dentz
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help