Re: [PATCH 1/6] Bluetooth: mgmt: Allow connectable/discoverable changes in off state

Hi Johan,

On Tue, Feb 21, 2012 at 07:43:44PM +0200, johan.hedberg@gmail.com wrote:

From: Johan Hedberg <redacted>

This patch makes it possible to toggle the connectable & discoverable
settings when powered off. Two new hdev->dev_flags flags are added to
track what the scan mode should be when the device is finally powered
on.

Signed-off-by: Johan Hedberg <redacted>

...

+
+	if (!!cp->val == test_bit(HCI_DISCOVERABLE, &hdev->dev_flags)) {

Is this really the best we can do? Also applies to other similar code.

Best regards 
Andrei Emeltchenko