Thread (7 messages) 7 messages, 2 authors, 2012-01-21

Re: [PATCH] Bluetooth: silence lockdep warning

From: Marcel Holtmann <marcel@holtmann.org>
Date: 2012-01-21 18:29:22

Hi Octavian,
quoted
quoted
+void bt_sock_reclassify_lock(struct sock *sk, int proto)
 {
-     struct sock *sk = sock->sk;
-
      if (!sk)
              return;
Why are we keeping the !sk check here if we already hand in the sk. It
is most likely checked by the caller already.
In rfcomm_sock_create (called from bt_sock_create) sock->sk can be set
to NULL so I think we should keep the check.
it has been too long since I looked at this part of the code. You need
to walk me through it why this is still true.

Regards

Marcel

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help