Thread (16 messages) 16 messages, 4 authors, 2012-02-02

Re: [RESEND 1/3] Bluetooth: Use cancel_work instead of cancel_work_sync

From: Marcel Holtmann <marcel@holtmann.org>
Date: 2012-01-31 15:11:37

Hi Andrei,
quoted
quoted
-       cancel_delayed_work_sync(&conn->disc_work);
+       cancel_delayed_work(&conn->disc_work);
I'm afraid we must use _sync variant here. disc_work is not supposed to
be running after hci_conn is deleted.

BTW, I believe we already addressed this issue in patches [PATCH 1/2]
Bluetooth: Fix potential deadlock and [PATCH 2/2] Bluetooth: Remove
unneeded locking. These patches are now pushed upstream. Could you
I will check those patches from upstream and let you know.
crap, I just acked these.

Johan, forget about my acks and just ignore them. Lets wait until we get
a clean new series.

Regards

Marcel

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help