Thread (11 messages) flat view 11 messages, 4 authors, 2011-12-05

Re: [PATCH 1/2] Provide return status in gatt_service_add function

From: Santiago Carot <hidden>
Date: 2011-12-02 11:43:24

Hi Johan,

2011/12/2 Johan Hedberg [off-list ref]:
Hi Santiago,

On Thu, Nov 24, 2011, Santiago Carot-Nemesio wrote:
quoted
Service plugins using the new GATT API may need to know if their attributes
were successfuly retgistered. In this way, plugins might abort loading
operation if they weren't registered.
---
 attrib/gatt-service.c |   15 +++++++++------
 attrib/gatt-service.h |    2 +-
 2 files changed, 10 insertions(+), 7 deletions(-)
Both patches applied after fixing typos in your commit messages. Thanks.
When I was working in this stuff, I was wondering if there may exist
the case when a plugin registers several services and the last one
fails, Do you think it would have sense to provide the service ID as
return parameter to allow plugins remove their attributes before
aborting the loading operation?, On the other hand, this feature would
raise the posibility of finding gaps in the distribution of handlers
assigned in GATT due that plugins could add and remove services
dynamically, I'm not sure if that is expected in GATT.

Waiting comments.
Regards
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help