Thread (22 messages) 22 messages, 3 authors, 2011-12-27

Re: [PATCH 05/12] Bluetooth: Don't use *_bh locks anymore

flat view

From: Gustavo Padovan <hidden>
Date: 2011-12-27 17:37:25

Hi Marcel,

* Marcel Holtmann [off-list ref] [2011-12-22 11:49:18 -0800]:
Hi Gustavo,
quoted
Those locks are not shared between interrupt and process context anymore,
so remove the part that disable interruption. We are stiff safe because
preeption is disabled.

Signed-off-by: Gustavo F. Padovan <redacted>
---
 net/bluetooth/l2cap_core.c |   24 ++++++++++++------------
 1 files changed, 12 insertions(+), 12 deletions(-)
any reason why this can not be converted into RCU usage?
Yes, when the element is added to the list its psm and cid both equals to 0.
In a following call the psm or cid is set, but at this point, we can't let a
reader read an old version of these value, this may cause two socket to
succeed on trying to connect to the same psm for example. spin lock is the
only safe choice here I think.

	Gustavo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help