Thread (3 messages) 3 messages, 2 authors, 2011-11-18

Re: [PATCH RFC BlueZ] serial: Fix bogus errno usage

flat view

From: Anderson Lizardo <hidden>
Date: 2011-11-18 12:15:15

Hi Johan,

On Fri, Nov 18, 2011 at 7:27 AM, Johan Hedberg [off-list ref] wrote:
bt_io_connect is not supposed to touch errno, so please don't send
patches for that. If you want to get the exact error you pass a GError
pointer, however even without that it's valid to check at least for a
NULL return. A simple fix if you don't want to add GError to this port.c
function is to return e.g. -EIO in case bt_io_connect returns NULL.
I just sent another patch that uses GError if it is set. I hope this
way it works just like the bt_io_connect() call in get_record_cb(), on
the same file.

Regards,
-- 
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help