Re: [PATCH 2/2] Bluetooth: Remove magic bluetooth version numbers

Hi Andrei,

quoted

quoted

+/* Bluetooth versions */
+#define BLUETOOTH_VER_1_1	1
+#define BLUETOOTH_VER_1_2	2
+#define BLUETOOTH_VER_2_0_EDR	3
+

I am fine with the patch, but you need to use BLUETOOTH_VER_2_0 here
since you have have 2.0 without EDR. Have a fun night reading with the
Bluetooth SIG branding guidelines.

OK, I will remove EDR at the end. BTW: on a bluetooth web site there seems
to be different interpretation of those numbers:

Parameter Name 	Assigned Values
HCI_Version 	
        0 	Bluetooth Core Specification 1.0b
  	1 	Bluetooth Core Specification 1.1
  	2 	Bluetooth Core Specification 1.2
  	3 	Bluetooth Core Specification 2.0 + EDR
  	4 	Bluetooth Core Specification 2.1 + EDR
  	5 	Bluetooth Core Specification 3.0 + HS
  	6 	Bluetooth Core Specification 4.0
  	7 - 255 	Reserved

they are actually wrong. The + XXX suffix is described in the Bluetooth
branding guidelines.

For example you can only call your product 3.0 + HS if you have a 2.1 or
3.0 controller (yes 2.1 is fine as well) with an AMP controller and
support for High Speed.

So the + XXX is pure product branding and has nothing to do with HCI or
LMP versions.

Regards

Marcel