Re: [PATCH] Fix byte order problems getting PSM through btio API
From: Santiago Carot <hidden>
Date: 2011-11-30 16:44:21
Hello, 2011/11/30 Santiago Carot-Nemesio [off-list ref]:
quoted hunk ↗ jump to hunk
--- btio/btio.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/btio/btio.c b/btio/btio.c index a129bf9..f8c5cc7 100644 --- a/btio/btio.c +++ b/btio/btio.c@@ -882,7 +882,7 @@ static gboolean l2cap_get(int sock, GError **err, BtIOOption opt1,break; case BT_IO_OPT_PSM: *(va_arg(args, uint16_t *)) = src.l2_psm ? - src.l2_psm : dst.l2_psm; + btohs(src.l2_psm) : btohs(dst.l2_psm); break; case BT_IO_OPT_CID: *(va_arg(args, uint16_t *)) = src.l2_cid ? -- 1.7.7.4
At a first sight, It seems there may be the same problems retrieving CID, OMTU and IMTU on big endian architectures. I preffer waiting for a more experienced comments before sending any patch fixing that. Regards.