Re: [PATCH v3] fix build
From: Andrei Emeltchenko <hidden>
Date: 2011-10-18 08:19:55
On Mon, Oct 17, 2011 at 05:56:05PM +0200, Frédéric Danis wrote:
quoted hunk ↗ jump to hunk
src/eir.c: In function 'eir_parse': src/eir.c:72: error: 'name_len' may be used uninitialized in this function and thermometer/thermometer.c: In function 'destroy_char': thermometer/thermometer.c:79: error: implicit declaration of function 'g_slist_free_full' --- src/eir.c | 2 +- thermometer/thermometer.c | 5 +++++ 2 files changed, 6 insertions(+), 1 deletions(-)diff --git a/src/eir.c b/src/eir.c index 8772191..8ada364 100644 --- a/src/eir.c +++ b/src/eir.c@@ -69,7 +69,7 @@ int eir_parse(struct eir_data *eir, uint8_t *eir_data) uuid_t service; char *uuid_str; const char *name = NULL; - size_t name_len; + size_t name_len = 0;
BTW: shall we change build flags otherwise bluez is not building anymore. make make --no-print-directory all-am CC src/eir.o cc1: warnings being treated as errors src/eir.c: In function ‘eir_parse’: src/eir.c:73:9: error: ‘name_len’ may be used uninitialized in this function make[1]: *** [src/eir.o] Ошибка 1 make: *** [all] Ошибка 2 Best regards Andrei Emeltchenko
quoted hunk ↗ jump to hunk
unsigned int i; eir->flags = -1;diff --git a/thermometer/thermometer.c b/thermometer/thermometer.c index 7621926..653ec76 100644 --- a/thermometer/thermometer.c +++ b/thermometer/thermometer.c@@ -20,6 +20,10 @@ * */ +#ifdef HAVE_CONFIG_H +#include <config.h> +#endif + #include <gdbus.h> #include <errno.h> #include <bluetooth/uuid.h>@@ -34,6 +38,7 @@ #include "att.h" #include "gatt.h" #include "thermometer.h" +#include "glib-helper.h" #define THERMOMETER_INTERFACE "org.bluez.Thermometer"-- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html