Thread (13 messages) flat view 13 messages, 2 authors, 2011-10-20

Re: [PATCH 5/8] Enable final measurement indications when first watcher is enabled

From: Santiago Carot <hidden>
Date: 2011-10-20 12:54:22

Hi Anderson,

2011/10/20 Anderson Lizardo [off-list ref]:
Hi Santiago,

On Thu, Oct 20, 2011 at 6:46 AM, Santiago Carot-Nemesio
[off-list ref] wrote:
quoted
+static void final_measurement_cb (guint8 status, const guint8 *pdu,
+                                               guint16 len, gpointer user_data)
There should be no space before "(" in function definitions/declarations.
quoted
+{
+       gchar *msg = user_data;
+
+       if (status != 0) {
+               error("%s failed", msg);
You don't need to g_free(msg) in case of error?
Yes I do, good catch!, I'll work in a new set of patches.
Thank for your comments.
quoted
+               return;
+       }
+
+       g_free(msg);
+}
+
Regards,
--
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help