Thread (3 messages) flat view 3 messages, 3 authors, 2011-10-21

Re: [PATCH v3] Simplify eir_parse_uuid* functions

From: Anderson Lizardo <hidden>
Date: 2011-10-20 20:27:30

Hi Frédéric,

2011/10/20 Frédéric Danis [off-list ref]:
+                       if (eir->name)
+                               g_free(eir->name);
You don't need to check for NULL before passing a pointer to g_free().
IMHO just "g_free(eir->name)" is clearer.
+
+                       eir->name = g_strndup((char *) &eir_data[2],
                                                               field_len - 1);
-                       else
-                               eir->name = g_strdup("");
                       eir->name_complete = eir_data[1] == EIR_NAME_COMPLETE;
                       break;
Regards,
-- 
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help