Thread (16 messages) flat view 16 messages, 4 authors, 2011-12-20
STALE5377d

[PATCH cover letter] Bluetooth: Revert: Fix L2CAP connection ...

From: Arek Lichwa <hidden>
Date: 2011-10-26 09:23:21

Hi

We found during testing problem when setting rfcomm (SPP) channel between
two 2.1 devices. 
The test case always failed mostly saying security block on l2cap level 
but sometimes the fail root cause was 'Command not understood' on l2cap 
as well.
Analyzing security block issue, I found that there's unencrypted link when
l2cap command 'connection request' is sent to remote.
The second issue with 'command not understood' has turn out to be related to 
expiration of l2cap timer and its implications.

Solution that I found to fix the problem seems to be related to old commit 
330605423ca6eafafb8dcc27502bce1c585d1b06 made by Ilia Kolomisnky. When there's
authentication ongoing, 'encryption pending' should be turn on, otherwise 
there're situations when link stays unencrypted. 
The issue with timer expiration is related to Andrzej Kaczmarek's patch 
sent to community a couple days ago (~ 2011/10/20). 
This patch actually recalculates (repairs) timer values on l2cap which were 
wrongly converted before. 
With this patch the expiration issue disappears during the test case 
I've made, otherwise just reverting 330605423ca6eafafb8dcc27502bce1c585d1b06
is not enough, since timer issue blocks very often passing the test case.

@Ilia: Can you point out what was the root cause of problems with time-outs
on l2cap that push you send the patch [605423ca6eafafb8dcc27502bce1c585d1b06].
Isn't it to be related to the patch that repairs the l2cap timer values 
mentioned above ?

BR,
/Arek

Arek Lichwa (1):
  Bluetooth: Revert: Fix L2CAP connection establishment

 net/bluetooth/hci_conn.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

-- 
1.7.6
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help