Re: [PATCH 11/23] avrcp: handle SetPlayerApplicationSettingValue pdu

On Mon, Aug 8, 2011 at 5:31 AM, Luiz Augusto von Dentz
[off-list ref] wrote:

Hi Lucas,

On Fri, Aug 5, 2011 at 9:15 PM, Lucas De Marchi
[off-list ref] wrote:

quoted

+static void append_variant(DBusMessageIter *iter, int type, void *val)
+{
+       DBusMessageIter value;
+       char sig[2] = { type, '\0' };
+
+       dbus_message_iter_open_container(iter, DBUS_TYPE_VARIANT, sig, &value);
+
+       dbus_message_iter_append_basic(&value, type, val);
+
+       dbus_message_iter_close_container(iter, &value);
+}

There should be possible to use dict_append_entry(src/dbus-common.h)
here, isn't it?

No, because it's not a dict (see that dict_append_entry calls
dbus_message_iter_open_container() ).

I could create a method for this in dbus-common, so it'd be useful for
others. What do you think?


Lucas De Marchi