Thread (2 messages) flat view 2 messages, 2 authors, 2011-08-09

Re: [PATCH obexd] Fix missing Name header check in FTP action code

From: Johan Hedberg <hidden>
Date: 2011-08-09 10:00:37

Hi Slawek,

On Tue, Aug 09, 2011, Slawomir Bochenski wrote:
---
 plugins/ftp.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
Applied, but with a minor coding-style modification:
 	name = obex_get_name(os);
+
+	if (name == NULL || !is_filename(name))
+		return -EBADR;
Usually when we have an assignment to a variable and then an immediately
following check for the variable there's no empty line between the
assignment and the if-statement, so I removed this empty line.

Johan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help