Thread (25 messages) flat view 25 messages, 5 authors, 2011-07-19

Re: [PATCH] adaptername: Move adapter naming into a plugin

From: Bastien Nocera <hadess@hadess.net>
Date: 2011-06-07 10:03:34

On Tue, 2011-06-07 at 11:49 +0200, Daniele Forsi wrote:
2011/6/7 Bastien Nocera:
quoted
diff --git a/src/adapter.c b/src/adapter.c
quoted
@@ -938,38 +884,29 @@ void adapter_update_local_name(struct btd_adapter *adapter, const char *name)
quoted
+               int err = adapter_ops->set_name(adapter->dev_id, name);
+               if (err < 0)
+                       return -err;
this should be:
return err;
else the error isn't detected in the calling code:
Good catch, fixed now.
quoted
+       err = adapter_update_local_name (adapter, name);
+       if (err < 0)
+               return btd_error_failed(msg, strerror(-err));
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help