Re: [PATCH obexd 4/4] Add copy and move support for filesystem plugin

Hi Hendric,

On Fri, Jun 17, 2011 at 1:28 PM, Hendrik Sattler
[off-list ref] wrote:

Zitat von Luiz Augusto von Dentz [off-list ref]:

quoted

From: Luiz Augusto von Dentz <redacted>

Move is implemented using rename and copy uses sendfile, both part of
posix.

Did you ever take a look at the "cp" implementation in coreutils? [1]
Additionally, the obex spec says that the copy/move actions also
copies/moves directories recursively.

Well need to check in the spec because for deleting recursively is not
mandatory so I supposed the copy/move wouldn't be either.  As for cp,
I did look, obviously I won't incorporate that much of code in obexd
and sendfile does actually do a lot of the checks there without
copying the data to the userspace. So what really is your point here,
that I should call system cp instead of sendfile?

-- 
Luiz Augusto von Dentz