Re: [RFC] Health Thermometer Profile API
From: Elvis Pfutzenreuter <hidden>
Date: 2011-06-21 18:06:25
On Jun 21, 2011, at 12:56 PM, Santiago Carot wrote: (cut)
quoted
Another option would be to guarantee that MeasureReceived() is called right after agent registering, in order to give the client an initial value to show (having in mind that notification interval might be very long).I would prefer to use the Final and Intermediate properties too. The problem that we should address occurs when an application wich hasn't got a watcher registered sets Intermediate or Final measurement property and the last watcher is removed. I think that the best option may be turn off measurments for power safe due that no watcher will get the measures.
I'm not sure I follow. Enabling intermediate and/or final notifications is done per-agent basis; if any of active agents needs intermediate measurements, device is configured to send them. Disabling it on one agent should not hurt another.
We can change the API to do that. What do you think?quoted
quoted
+ + +Health Thermometer Watcher hierarchy +==================================== +Service unique name +Interface org.bluez.ThermometerWatcher +Object path freely definable + +Methods void MeasureReceived(dict measure) + + This callback gets called when a measure has been + scanned in the thermometer. The Value entry corresponds + to IEEE-11073 32-bit FLOAT.The Time entry in the dict + will be only present if the device supports storing of + data. The time value is expressed in seconds since epoch.Using such a special type (FLOAT) looks funny. Not sure whether it is the best option for this API. At the very least, a description of FLOAT type should be added to the API, since IEEE 11073 specs are not public/free, and API users would have to resort to unofficial source to learn it. I understand why you used this type (keeps the thermometer transcodable through this API and there are the special values), so BTW the lack of device information service access through this API should at least be mentioned, so we ammend that later (either here or adding another API)....or we can split the value in their exponent and mantissa components. Any suggestion?
I'd go for that, but we need to take a look on special values to see if it makes sense. It would be really ugly to say something like "if mantissa=5 and exponent=-3 then temperature is actually zero" :)