Thread (7 messages) flat view 7 messages, 3 authors, 2011-06-29

RE: [PATCH] Bluetooth: Ath3k keeps same PID/VID after downloading the patch and radio table

From: Li, Steven <hidden>
Date: 2011-06-29 07:19:13

Hi Padovan :
quoted
quoted
quoted
quoted
I would say something similar in style
to what I have done for the older CSR chips. See workaround above=
.
quoted
quoted
quoted
quoted
And on that note, you could use data->udev to get the usb_device
struct ;)
As to this point,  since now we are not using the btusb to download=
 the
quoted
quoted
patch and radio table,
quoted
 I think we do not need to alloc the data struct and use data->udev
before
quoted
quoted
the workaround.
quoted
So I'll still keep it was.  How do you think it ?
No, there is no extra allocation. data->udev is already there. Just u=
se it as
quoted
quoted
Marcel said.
There is somehow different with  the older CSR chips.
We need to return -NODEV directly if the bcd version of the 3012 chip i=
s
lower or equal to 0x0001,
quoted
And I think in such "return -NODEV" case, we totally do not need to all=
oc
the btusb_data.
=20
Ah yes, you right, I misread the patch.
=20
I have re-sent the patch to the mail list.
Btw, I changed the subject of the PATCH to make it be less than 60 characte=
rs.

Thanks, Padovan,
Steven,
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help