Thread (5 messages) flat view 5 messages, 2 authors, 2011-06-30
STALE5530d

[PATCH 1/3] avrcp: Check that AVCTP packet is of type COMMAND

From: Lucas De Marchi <hidden>
Date: 2011-06-30 18:50:33
Subsystem: the rest · Maintainer: Linus Torvalds

---
 audio/control.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/audio/control.c b/audio/control.c
index 3db7d8e..57a4edc 100644
--- a/audio/control.c
+++ b/audio/control.c
@@ -590,7 +590,8 @@ static gboolean control_cb(GIOChannel *chan, GIOCondition cond,
 			operands[1] = SUBUNIT_PANEL << 3;
 		DBG("reply to %s", avrcp->opcode == OP_UNITINFO ?
 				"OP_UNITINFO" : "OP_SUBUNITINFO");
-	} else if (avrcp->opcode == OP_VENDORDEP) {
+	} else if (avctp->cr == AVCTP_COMMAND &&
+			avrcp->opcode == OP_VENDORDEP) {
 		/* Reply with REJECT msg with error code 0x0
 		 * (Invalid Command) as defined in AVRCP spec (6.15.1) */
 		struct avrcp_spec_avc_pdu *pdu = (void *) operands;
-- 
1.7.6
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help