Thread (5 messages) read the whole thread 5 messages, 2 authors, 2011-05-20

Re: [PATCH v3 1/2] Fix change to numbers GSlist in new missed calls

From: Johan Hedberg <hidden>
Date: 2011-05-19 23:34:01

Hi Dmitriy,

On Thu, May 19, 2011, Dmitriy Paliy wrote:
It is possible that phonebook_pull_read is invoked several times
submitting multiple pull requests without closing PBAP object. E.g.,
when history is large enough and maxlistcount>VCARDS_PART_COUNT.

The result is possibility of different data structures (GString and
contact_data) to be mixed in a single GSlist that may lead to
undefined behaviour.
---
 plugins/phonebook-tracker.c |   57 ++++++++++++++++++++++++-------------------
 1 files changed, 32 insertions(+), 25 deletions(-)
Both patches have been pushed upstream. Could you still explain what
data->numbers is supposed to be useful for? It's not used anywhere in
the code (except where creating and freeing the list).

Johan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help