Thread (4 messages) flat view 4 messages, 4 authors, 2011-05-25

Re: Question about ABORT when canceling OPP file transfer

From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: 2011-05-25 11:50:43

Hi Radek,

On Wed, May 25, 2011 at 10:39 AM,  [off-list ref] wrote:
Hi Johan,

There is one PTS test for OPP which tests if we're disconnecting cleanly
when cancelling outgoing file transfer (this test is not mandatory).
Currently it fails, because we don't send ABORT before disconnect.
Just to confirm, this test is for client, right?
I've noticed that code for handling it nicely already exist in
gw_obex_xfer_do_abort(...) but is disabled by default (via
USE_NICE_ABORT definition).

Is it safe to change that and  use "nice abort" by default? Were there problems
with handling this ABORT command by some devices in described scenario?
Well if you want to have this test to pass obviously you need to send
abort properly, in the other hand I think we should make this a proper
API on gwobex so the application using it can pass to
gw_obex_xfer_do_abort how it wants to abort.

Regards,

-- 
Luiz Augusto von Dentz
Computer Engineer
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help