Re: [RFCv1 2/3] Bluetooth: remove duplicated code
From: Gustavo F. Padovan <hidden>
Date: 2011-03-24 18:57:59
Hi Andrei, * Emeltchenko Andrei [off-list ref] [2011-03-24 17:16:07 +0200]:
quoted hunk ↗ jump to hunk
From: Andrei Emeltchenko <redacted> info_timer takes care about removed code Signed-off-by: Andrei Emeltchenko <redacted> --- net/bluetooth/l2cap_core.c | 12 +++--------- 1 files changed, 3 insertions(+), 9 deletions(-)diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c index fd58b8f..4255f00 100644 --- a/net/bluetooth/l2cap_core.c +++ b/net/bluetooth/l2cap_core.c@@ -2472,16 +2472,10 @@ static inline int l2cap_information_rsp(struct l2cap_conn *conn, struct l2cap_cm return 0; } - del_timer(&conn->info_timer); - - if (result != L2CAP_IR_SUCCESS) { - conn->info_state |= L2CAP_INFO_FEAT_MASK_REQ_DONE; - conn->info_ident = 0; - - l2cap_conn_start(conn);
Are you sure? Does remove this code won't create a delay to call l2cap_conn_start()? -- Gustavo F. Padovan http://profusion.mobi