Thread (3 messages) flat view 3 messages, 2 authors, 2011-03-27
STALE5610d

[PATCH 1/2] Fix memory leak if an error occurs when a data channel is reconnected.

From: Santiago Carot-Nemesio <hidden>
Date: 2011-03-25 17:39:21
Subsystem: the rest · Maintainer: Linus Torvalds

---
 health/hdp.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/health/hdp.c b/health/hdp.c
index 3c2dce1..7a4b219 100644
--- a/health/hdp.c
+++ b/health/hdp.c
@@ -514,9 +514,9 @@ static void hdp_mdl_reconn_cb(struct mcap_mdl *mdl, GError *err, gpointer data)
 		reply = g_dbus_create_error(dc_data->msg,
 						ERROR_INTERFACE ".HealthError",
 						"Cannot get file descriptor");
-
-	reply = g_dbus_create_reply(dc_data->msg, DBUS_TYPE_UNIX_FD, &fd,
-							DBUS_TYPE_INVALID);
+	else
+		reply = g_dbus_create_reply(dc_data->msg, DBUS_TYPE_UNIX_FD,
+							&fd, DBUS_TYPE_INVALID);
 	g_dbus_send_message(dc_data->conn, reply);
 }
 
-- 
1.7.4.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help