Thread (8 messages) flat view 8 messages, 2 authors, 2011-04-09

Re: [PATCH v2] Add sap_disconnect_ind interface for sap-sim drivers

From: Johan Hedberg <hidden>
Date: 2011-03-28 09:55:57

Hi Waldek,

On Mon, Mar 28, 2011, Waldemar.Rymarkiewicz@tieto.com wrote:
quoted
Are you planning to have some additional Disconnect* method in 
the future since you didn't reuse the existing "Disconnect" 
method name for this? The patch is also missing the 
corresponding update to sap-api.txt.
The Disconnect method mentioned in sap-api.txt is implemented in
server.c and it's the gracefull disconnect. The one I've changes in
the patch is used in sap-dummy.c driver, which is used for tests only.

The original idea was to have Disconnect(type) method in server.c, but
finally, in a discussion, we came to the conclusion that the immediate
disconnect should not be used by user. Driver should handle this if
it's needed.

So, sap-api.txt stays unchanged, and dummy-driver is changed to be
able to pass some of  PTS tests.
Ok, sounds fine to me.

Johan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help