Hi Waldek,
On Mon, Mar 28, 2011, Waldemar.Rymarkiewicz@tieto.com wrote:
quoted
Are you planning to have some additional Disconnect* method in
the future since you didn't reuse the existing "Disconnect"
method name for this? The patch is also missing the
corresponding update to sap-api.txt.
The Disconnect method mentioned in sap-api.txt is implemented in
server.c and it's the gracefull disconnect. The one I've changes in
the patch is used in sap-dummy.c driver, which is used for tests only.
The original idea was to have Disconnect(type) method in server.c, but
finally, in a discussion, we came to the conclusion that the immediate
disconnect should not be used by user. Driver should handle this if
it's needed.
So, sap-api.txt stays unchanged, and dummy-driver is changed to be
able to pass some of PTS tests.
Ok, sounds fine to me.
Johan